New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport get_num_cpu fixes to Version 12.0 #9463

Merged

eivindjahren merged 3 commits into equinor:version-12.0 from eivindjahren:version-12.0

Dec 5, 2024

Contributor

eivindjahren commented Dec 5, 2024

Backports #9640 and #9395

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Create Backport PR to latest release

berland and others added 3 commits

December 5, 2024 15:13


          Add more DATA parsing tests for num_cpu

524a5ec


          Fix a bug with skipping two lines after TITLE

8e83d37


          Fix crash when reading num_cpu from non-ascii files

72586e7

eivindjahren changed the title ~~Version 12.0~~ Backport get_num_cpu fixes to Version 12.0

berland approved these changes

View reviewed changes

eivindjahren enabled auto-merge (rebase)

December 5, 2024 14:22

eivindjahren merged commit 8d723aa into equinor:version-12.0

40 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet