Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused evaluate method in ensemble_evaluator_utils #9472

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 6, 2024

Approach
✂️
(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq added release-notes:improvement Automatically categorise as improvement in release notes release-notes:maintenance Automatically categorise as maintenance change in release notes and removed release-notes:improvement Automatically categorise as improvement in release notes labels Dec 6, 2024
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare bra! Nice ✂️

@jonathan-eq jonathan-eq enabled auto-merge (rebase) December 6, 2024 11:34
@jonathan-eq jonathan-eq merged commit 4b34fc9 into equinor:main Dec 6, 2024
39 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (b903bb0) to head (64fc09a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9472      +/-   ##
==========================================
- Coverage   91.86%   91.83%   -0.03%     
==========================================
  Files         433      433              
  Lines       26654    26686      +32     
==========================================
+ Hits        24486    24508      +22     
- Misses       2168     2178      +10     
Flag Coverage Δ
cli-tests 39.40% <ø> (-0.04%) ⬇️
everest-models-test 34.80% <ø> (-0.02%) ⬇️
gui-tests 72.28% <ø> (-0.10%) ⬇️
integration-test 37.06% <ø> (-0.02%) ⬇️
performance-tests 52.01% <ø> (-0.06%) ⬇️
test 40.75% <ø> (+<0.01%) ⬆️
unit-tests 74.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants