Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everest snapshot egg-py311.csv #9481

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Dec 6, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Dec 6, 2024
@DanSava DanSava force-pushed the update-egg-snapshot branch from a61ff55 to ff7f494 Compare December 6, 2024 14:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (90c14a9) to head (ff7f494).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9481   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         434      434           
  Lines       26735    26735           
=======================================
+ Hits        24551    24553    +2     
+ Misses       2184     2182    -2     
Flag Coverage Δ
cli-tests 39.32% <ø> (ø)
everest-models-test 34.74% <ø> (ø)
gui-tests 72.15% <ø> (+0.02%) ⬆️
integration-test 37.01% <ø> (+0.02%) ⬆️
performance-tests 51.91% <ø> (ø)
test 40.68% <ø> (ø)
unit-tests 74.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frode-aarstad frode-aarstad merged commit baeb4f5 into equinor:main Dec 6, 2024
39 checks passed
@DanSava DanSava deleted the update-egg-snapshot branch December 6, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants