Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using "cached" testdata in test_export.py #9484

Merged

Conversation

yngve-sk
Copy link
Contributor

@yngve-sk yngve-sk commented Dec 9, 2024

No description provided.

@yngve-sk yngve-sk self-assigned this Dec 9, 2024
@yngve-sk yngve-sk force-pushed the 24.12.09.stop_mocking_in_everexport_test branch 3 times, most recently from d3fa2b9 to 2861a2f Compare December 9, 2024 13:48
@yngve-sk yngve-sk force-pushed the 24.12.09.stop_mocking_in_everexport_test branch from 2861a2f to 04c5c54 Compare December 9, 2024 14:01
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (baeb4f5) to head (04c5c54).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9484      +/-   ##
==========================================
- Coverage   91.83%   91.83%   -0.01%     
==========================================
  Files         434      434              
  Lines       26735    26751      +16     
==========================================
+ Hits        24553    24567      +14     
- Misses       2182     2184       +2     
Flag Coverage Δ
cli-tests 39.33% <ø> (+0.01%) ⬆️
everest-models-test 34.73% <ø> (-0.01%) ⬇️
gui-tests 72.12% <ø> (-0.01%) ⬇️
integration-test 37.00% <ø> (+0.01%) ⬆️
performance-tests 51.92% <ø> (+0.01%) ⬆️
test 40.65% <ø> (-0.04%) ⬇️
unit-tests 74.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk merged commit 8e00339 into equinor:main Dec 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants