Log when evaluator is leaving events #9487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9487 +/- ##
==========================================
+ Coverage 91.92% 91.94% +0.01%
==========================================
Files 433 433
Lines 26734 26740 +6
==========================================
+ Hits 24575 24585 +10
+ Misses 2159 2155 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andreas-el
approved these changes
Dec 10, 2024
|
On second thought, I don't think the time measurement in this PR makes sense, it it just timing putting a list into a queue, which is not interesting. Will have a second look. |
The batching interval and size can maybe be tuned slightly, before that it will be quite interesting to know how often message processing is postponed. This logging feature existed in the sync version of the ensemble evaluator, but was not carried over in 509c224.
berland
force-pushed
the
log_left_in_queue
branch
from
039c454 to
493a3d2
Compare
|
Trying again. Another review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batching interval and size can maybe be tuned slightly, before that it will be quite interesting to know how often message processing is postponed.
This logging feature existed in the sync version of the ensemble evaluator, but was not carried over in 509c224.
Issue
Resolves https://github.com/equinor/komodo-releases/issues/6373
Approach
Reinstate.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable