Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rerunning on mda #9492

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 10, 2024

Issue
Resolves #9467

Approach
Disable the rerun failed button in gui, and remove unused mock methods in BRM tests

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Dec 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (ad786d8) to head (68de803).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9492      +/-   ##
==========================================
+ Coverage   91.83%   91.85%   +0.01%     
==========================================
  Files         434      434              
  Lines       26763    26764       +1     
==========================================
+ Hits        24579    24585       +6     
+ Misses       2184     2179       -5     
Flag Coverage Δ
cli-tests 39.37% <100.00%> (+<0.01%) ⬆️
everest-models-test 34.73% <0.00%> (-0.01%) ⬇️
gui-tests 72.15% <100.00%> (+0.03%) ⬆️
integration-test 37.00% <0.00%> (-0.01%) ⬇️
performance-tests 51.91% <0.00%> (-0.02%) ⬇️
test 40.67% <0.00%> (-0.01%) ⬇️
unit-tests 74.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 🚀

@jonathan-eq jonathan-eq merged commit ae94407 into equinor:main Dec 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total progress bar exceeds 100
3 participants