Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarking with codspeed #9530

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Dec 13, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 23 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] (6.6 ms)
  • test_and_benchmark_adaptive_localization_with_fields (17 s)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_parameters] (145.4 µs)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_csv] (11.2 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_parquet] (17.2 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_parameters] (144 µs)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_csv] (11.1 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_parquet] (17.2 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary-get_parameters] (148.5 µs)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_csv] (13.3 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_parquet] (20.5 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_parameters] (144 µs)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_record_csv] (13.2 ms)
  • test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_record_parquet] (20.1 ms)
  • test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] (1.6 ms)
  • test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] (2.7 ms)
  • test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary-get_record_observations] (1.3 ms)
  • test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_record_observations] (4.1 ms)
  • test_gui_snapshot (7.3 s)
  • test_snapshot_handling_of_forward_model_events[10-10-10] (39.1 ms)
  • test_snapshot_handling_of_forward_model_events[10-10-1] (10.6 ms)
  • test_snapshot_handling_of_forward_model_events[10-100-1] (99 ms)
  • test_snapshot_handling_of_forward_model_events[100-10-1] (104.4 ms)

@eivindjahren eivindjahren added christmas-review release-notes:maintenance Automatically categorise as maintenance change in release notes labels Dec 13, 2024
@eivindjahren eivindjahren requested a review from larsevj December 13, 2024 10:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (68d01c7) to head (169d447).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9530      +/-   ##
==========================================
- Coverage   91.87%   91.84%   -0.03%     
==========================================
  Files         433      433              
  Lines       26752    26768      +16     
==========================================
+ Hits        24579    24586       +7     
- Misses       2173     2182       +9     
Flag Coverage Δ
cli-tests 39.78% <ø> (+0.37%) ⬆️
everest-models-test 34.67% <ø> (-0.05%) ⬇️
gui-tests 72.15% <ø> (+<0.01%) ⬆️
integration-test 37.21% <ø> (+0.23%) ⬆️
performance-tests 52.00% <ø> (+0.01%) ⬆️
test 40.47% <ø> (-0.19%) ⬇️
unit-tests 74.12% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren force-pushed the add_codspeed branch 2 times, most recently from ca1cf10 to fd28987 Compare December 13, 2024 11:24
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eivindjahren eivindjahren merged commit 5ae6ece into equinor:main Dec 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants