Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated polars count with len #9544

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 13, 2024

Get following warning when running tests:

tests/ert/unit_tests/gui/simulation/test_run_path_dialog.py: 6 warnings
  /data/komodo_dev/ert/src/ert/gui/ertwidgets/models/ertsummary.py:40: DeprecationWarning: `GroupBy.count` is deprecated. It has been renamed to `len`.
    counts.extend(df.group_by("observation_key").count().to_dicts())  #  type: ignore
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 13, 2024
@larsevj larsevj force-pushed the fix_polars_warnings branch from 8859d26 to fc67cf4 Compare December 13, 2024 13:42
@larsevj larsevj requested a review from yngve-sk December 13, 2024 13:42
@larsevj larsevj self-assigned this Dec 13, 2024
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@larsevj larsevj merged commit a0dc76e into equinor:main Dec 18, 2024
39 checks passed
@larsevj larsevj deleted the fix_polars_warnings branch December 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants