Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test data #9582

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 18, 2024

Approach
🧹

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (01156bb) to head (dd4e9ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9582   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files         433      433           
  Lines       26768    26768           
=======================================
+ Hits        24587    24589    +2     
+ Misses       2181     2179    -2     
Flag Coverage Δ
cli-tests 39.75% <ø> (ø)
everest-models-test 34.58% <ø> (-0.01%) ⬇️
gui-tests 72.11% <ø> (+<0.01%) ⬆️
integration-test 37.19% <ø> (ø)
performance-tests 51.94% <ø> (ø)
test 40.47% <ø> (+0.02%) ⬆️
unit-tests 74.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #9582 will not alter performance

Comparing oyvindeide:remove_unused_test_data (dd4e9ab) with main (01156bb)

Summary

✅ 22 untouched benchmarks

@oyvindeide oyvindeide marked this pull request as ready for review December 18, 2024 10:01
@oyvindeide oyvindeide self-assigned this Dec 18, 2024
@oyvindeide oyvindeide merged commit b7b5774 into equinor:main Dec 18, 2024
41 checks passed
@oyvindeide oyvindeide deleted the remove_unused_test_data branch December 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants