Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Event reporter timeout after successful Finish event #9733

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Jan 14, 2025

Issue
Resolves #9709

Approach
For the sake of heavy load when using LOCAL_DRIVER we set the default timeout to 10 minutes since forward model can be finished but not all the events were sent yet.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Jan 14, 2025
For the sake of heavy load when using LOCAL_DRIVER we set the default timeout to 10 minutes since forward model can be finished but not all the events were sent yet.

Co-authored-by: Lars Evje <levje@equinor.com>
@xjules xjules force-pushed the fix_client_timeout branch from 68f56d3 to 55d7867 Compare January 14, 2025 09:44
Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #9733 will not alter performance

Comparing xjules:fix_client_timeout (55d7867) with main (60fc8f8)

Summary

✅ 24 untouched benchmarks

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@xjules xjules merged commit 0d9c178 into equinor:main Jan 14, 2025
36 checks passed
@xjules xjules deleted the fix_client_timeout branch January 14, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all forward model steps reported as finished despite all realizations were succesfull
2 participants