Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve safezone stability #1759

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Oct 11, 2024

This PR removes a lot of failure points and instabilities in the safezone (and therefore also the charging) functionality. In a future PR I also want to implement this: #1775 to further improve consistency. In this PR we now use localization poses if no safezone poses are found. In a future PR I would also like to handle this issue: #1528 by removing safezone poses and only using localization poses.

@andchiind andchiind added the improvement Improvement to existing functionality label Oct 11, 2024
@andchiind andchiind self-assigned this Oct 11, 2024
@andchiind andchiind marked this pull request as ready for review October 11, 2024 11:54
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Oct 15, 2024
@andchiind andchiind force-pushed the 1758-recharge-fix branch 5 times, most recently from f1f1824 to e1626bd Compare October 21, 2024 08:41
Copy link
Contributor

@mrica-equinor mrica-equinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@andchiind
Copy link
Contributor Author

/UpdateDatabase

Copy link

👀 Running migration command... 👀

Copy link

✨ Successfully ran migration command! ✨

@andchiind andchiind merged commit a355881 into equinor:main Oct 29, 2024
12 checks passed
@andchiind andchiind deleted the 1758-recharge-fix branch October 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database-change Will require migration improvement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants