Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify return to home and docking naming #1919

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Unify return to home and docking naming #1919

merged 1 commit into from
Jan 3, 2025

Conversation

andchiind
Copy link
Contributor

@andchiind andchiind commented Jan 2, 2025 •
edited
Loading

Closes #1793

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@andchiind andchiind added good first issue Good for newcomers backend Backend related functionality improvement Improvement to existing functionality labels Jan 2, 2025
@andchiind andchiind self-assigned this Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

oysand
oysand approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andchiind andchiind merged commit 36cdfeb into equinor:main Jan 3, 2025
14 checks passed
@andchiind andchiind deleted the 1793-unify-naming branch January 3, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oysand oysand oysand approved these changes

Assignees

@andchiind andchiind

Labels
backend Backend related functionality good first issue Good for newcomers improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Drive to docking station" and "Return to home" missions drive to same place but sound like different places
2 participants
@andchiind @oysand