DEP: Discontinue legacy schema #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
force-pushed
the
delete_legacy_schema
branch
from
1905454 to
15d644c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two schemas in fmu-dataio:
This PR removes the legacy one, and changes the schema generated by pydantic to
fmu_results.json. Resolves #571Sumo has for a while now used the new schema with name
fmu_meta.json. Therefore the new schema is copied and stored with this namefmu_meta.jsonwhen building the container in radix. This should be removed once Sumo updates the schema used tofmu_results.json.