TST: Add test to ensure all optional fields have defaults #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
force-pushed
the
test_optional_fields
branch
from
dbd8c79 to
cf3b1fe
Compare
|
The tests should fail now since we have one Optional field without a default present in the schema. |
|
Ok the docs failing is not related to this PR. Good 😄 |
mferrera
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
These tests will aid our inadequate human brains so much in the long run from making silly and forgetful but simulation killing mistakes. I imagine there are more we can build in as things come up -- i.e., models that derived from Data but are not placed into AnyData
| for field_name, field_info in model.model_fields.items(): | ||
| if ( | ||
| type(None) in get_args(field_info.annotation) | ||
| and field_info.is_required() |
There was a problem hiding this comment.
Did not know about is_required(), neat
tnatt
force-pushed
the
test_optional_fields
branch
4 times, most recently
from
9721e23 to
faf488e
Compare
tnatt
force-pushed
the
test_optional_fields
branch
from
faf488e to
fa4e5be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that adds a test (and relevant functionality) to check that all
optionalpydantic fields havedefaultvalues specified.Adresses #819