FIX: Open metadata with utf-8 encoding #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
open-metadata-as-utf-8
branch
2 times, most recently
from
4ef55b6 to
791a64a
Compare
When calling 'open' without specifying the encoding Python will use `locale.getencoding()` for Python 3.11+ and `locale.getpreferredencoding(False)` (with or without the `False`) for Python 3.8 to determine which encoding to open the file with. RMS in interactive mode sets this to ANSI_X3.4-1968 (a weird way of saying ascii). This can cause opening the file to fail when non-ascii characters are present within it.
mferrera
force-pushed
the
open-metadata-as-utf-8
branch
from
791a64a to
a3ede37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #978
When calling 'open' without specifying the encoding Python will use
locale.getencoding()for Python 3.11+ andlocale.getpreferredencoding(False)(with or without theFalse) for Python 3.8 to determine which encoding to open the file with.RMS sets this to ANSI_X3.4-1968 (a weird way of saying ascii). This can cause opening the file to fail when non-ascii characters are present within it.