FIX: Fix bug in writing new schema #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnatt
reviewed
Feb 12, 2025
tnatt
reviewed
Feb 12, 2025
| 5. Update the schemas for production | ||
| ```bash | ||
| ./tools/update-schemas --prod | ||
| ./tools/update-schemas --prod --force |
There was a problem hiding this comment.
I guess this is where my previous comment should be 🙂
Suggested change
| ./tools/update-schemas --prod --force | |
| ./tools/update-schema --prod --force |
There was a problem hiding this comment.
I don't know, I lean toward your first comment.. it's probably best to make all the things plural now
tnatt
reviewed
Feb 12, 2025
tnatt
approved these changes
Feb 12, 2025
mferrera
force-pushed
the
fix-update-schema-tool
branch
from
a59a48b to
e42254d
Compare
mferrera
force-pushed
the
fix-update-schema-tool
branch
from
e42254d to
f323999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #995
This occurred during a short demo. The function handling writing was way too complex and hard to understanding, so it was refactored into a class. Clarified some documentation at the same time.