You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The to_pandas implementation is inconsistently implemented. In Table, it is implemented as a property. While similar looking to_arrow is a method. Also, the name indicates that this should be a function. to_pandas is also a function in other object classes, e.g. Polygons.to_pandas().
🟩 This PR restructures the tests somewhat and adds tests for methods/functions that was not tested.
🟩 This PR changes Table.to_pandas from a property to a function. ⚠️Breaking change⚠️
It is strictly speaking not deprecated, but discontinued. Deprecating functionality would imply that mytable.to_pandas would continue to function, but be deprecated and to be discontinued in the future (typically documented in the docs and in addition yielding a DeprecationWarning). It would make the change a two step procedure, but allows consumers to migrate with an intermediate state yielding warnings, without immediately breaking the behaviour.
It is strictly speaking not deprecated, but discontinued. Deprecating functionality would imply that mytable.to_pandas would continue to function, but be deprecated and to be discontinued in the future (typically documented in the docs and in addition yielding a DeprecationWarning). It would make the change a two step procedure, but allows consumers to migrate with an intermediate state yielding warnings, without immediately breaking the behaviour.
True! Changed in the original text ✅
Do you know of a way to actually deprecate something like this (i.e. give warning but still work)? I could not find a way to redirect the propertyto_pandas to the functionto_pandas because it will mean def to_pandas(self) twice....
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve #267
The
to_pandasimplementation is inconsistently implemented. InTable, it is implemented as a property. While similar lookingto_arrowis a method. Also, the name indicates that this should be a function.to_pandasis also a function in other object classes, e.g.Polygons.to_pandas().🟩 This PR restructures the tests somewhat and adds tests for methods/functions that was not tested.⚠️ Breaking change ⚠️
🟩 This PR changes
Table.to_pandasfrom a property to a function.Old pattern (discontinued with this PR):
New pattern (introduced with this PR):