Add support for content filtering #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equinor-ruaj
approved these changes
Mar 7, 2024
Comment on lines
+112
to
+117
| def contents(self) -> List[str]: | ||
| """List of unique contents""" | ||
| return self._get_field_values("data.content.keyword") | ||
|
|
||
| @property | ||
| async def contents_async(self) -> List[str]: |
There was a problem hiding this comment.
Can it be confusing that these say contentS, while the metadata is content?
There was a problem hiding this comment.
Could be.. looks like we've gone with plurals for most of the other properties (names, tagnames, iterations, realizations, stages). Maybe we should switch strategy completely and add a method for getting unique values, so it would be something like surfaces.unique("data.content")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Link to the issue resolved by this PR.
Short description
Add
contentparameter tofiltermethods and add acontentsproperty for retrieving unique content values in a collection.Pre-review checklist
print()statements, commented-out code, or other remnants from the development. 👀Pre-merge checklist