Fixed bug where new note was not listed #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiaht
reviewed
Aug 25, 2021
frontend/src/components/ActionTable/ActionTableForOneUserWithApi.tsx
Outdated
Show resolved
Hide resolved
maiaht
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug: In the action list on either the Dashboard (1), or in the Follow-up tab (2),
(1)
(2)
when clicking on an action to open it in the side panel, and then writing a note, the note will not appear in the list of notes beneath the input field, even though the saved icon appears and the note seems to be saved. This problem does not happen when opening an action in the side panel in the questions view (3)
(3)
This fix: The problem was that we were sending a copy of the action to the side panel, and this copy had the old list of notes which then would not list the new note. Now, the action in the side panel is refreshed every time the component is refreshed, and will thus have the newest data.