Workflow: Move model notification up to top-level #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epa095
force-pushed
the
workflow_move_builder_svc_to_top_level
branch
from
3d879ad
to
4f1baf0
Compare
Simplifies the workflow by removing nested templates. I.e. instead of having a template consisting of building-then-post-service, we add the building and service-posting as top-level tasks in do-all, and add the builder as a dependency of the service. Needed beause of argoproj/argo-workflows#1713
epa095
force-pushed
the
workflow_move_builder_svc_to_top_level
branch
from
4f1baf0
to
342358e
Compare
epa095
changed the title
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=====================================
Coverage 91% 91%
=====================================
Files 62 62
Lines 2778 2778
=====================================
Hits 2528 2528
Misses 250 250Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the workflow by removing nested templates. I.e. instead of having
a template consisting of building-then-post-service, we add the building
and service-posting as top-level tasks in do-all, and add the builder as a
dependency of the service.
Needed beause of argoproj/argo-workflows#1713