Correctly reset tasks status request failure counter #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no throttling of the state machine while loop in this case but there should be. In the event where it failed to collect status due to a RobotCommunicationException it should also sleep before retrying to ensure throttling.
The old name did not indicate what the return boolean meant. The new name, combined with new variable name, should make the code more readable.
Previously, the failure counter would not be reset between tasks when running a mission wise mission. Instead, if it reached the counter once all subsequent tasks would fail with an ever increasing counter.
aeshub
force-pushed
the
address-task-status-bug
branch
from
fdb9a05 to
1d4a883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.