Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: avoid importing python package neqsim #15

Merged

Conversation

asmfstatoil
Copy link
Contributor

@asmfstatoil asmfstatoil commented Oct 17, 2024

when python package neqsim is already installed in the same environment, "import neqsim" will import the python package and not the java package.

@asmfstatoil
Copy link
Contributor Author

asmfstatoil commented Oct 17, 2024

I have tested this locally and with neqsimpython with the main issue of duplicate module names (python package neqsim and java package neqsim) solved. In python package neqsim I still need to import this package with

from jneqsim import neqsim as jneqsim

to avoid collisions within the same package.

@soofstad soofstad changed the base branch from main to avoid-importing-python-neqsim October 24, 2024 10:12
@soofstad soofstad merged commit 1768c5b into equinor:avoid-importing-python-neqsim Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants