Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@berland pinging you because I am not sure an automated email gets sent with draft PRs
Feel I should contribute to this as I was using it today to test some code I was writing internally. I made four changes:
Material
class. (this makes use offuture
import for old versions which may be a bummer for the devs so happy to roll back)hashin_shtrikman_walpole
bound
argument is checked to be either oflower
andupper
(it was written so that any string other thanlower
would give the upper bound. This could be breaking if someone somewhere has misspelled code!)I have identified some inconsistency regarding the types of attributes in the
Material
class, namely generating a material withhashin_shtrikman_average
has float attributes which I feel is discouraged over array of a single float. But this doesn't seem enforced so I haven't done anything about that.