Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/104582 handle scope handed over status #768

Merged
merged 8 commits into from
Jul 27, 2023

Conversation

AnneSkje
Copy link
Contributor

@AnneSkje AnneSkje commented Jul 21, 2023

Description

Please include a summary of the change and which issue is fixed.
List any external dependencies that are required for this change.

Completes: AB#104582

Checklist:

  • I have performed a self-review of my own code.
  • I have linked my DevOps task using the AB# tag.
  • My code is easy to read, and comments are added where needed.
  • My code is covered by tests.

@AnneSkje AnneSkje requested a review from VRiveland July 21, 2023 07:57
@github-actions github-actions bot added invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this labels Jul 21, 2023
Copy link
Contributor

@VRiveland VRiveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope handed over filter fungerer ikke i search IPO. Har ingen spesiell måte å vises på, selv om de ikke skal være mulige å endre.
Det ser ut som om IPOen bare er fullført på vanlig måte i view IPO, tror ikke at det bør gjøre det. Steps bør kanskje være annerledes?
Skal admin ha lov til å endre på IPOen etter at RFOC er signert?

Copy link
Contributor

@VRiveland VRiveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da skal alt fungere og se ok ut

@VRiveland VRiveland merged commit 7becb06 into master Jul 27, 2023
1 check passed
@VRiveland VRiveland deleted the feature/104582-Handle-ScopeHandedOver-status branch July 27, 2023 08:08
chormaz pushed a commit that referenced this pull request Sep 13, 2023
* Added ScopeHandedOver enumm and added to filter

* Unable to edit when scope handed over

* Removed step created when handed over

* Cannot edit when scope handed over

* Renamed files

* Improve readability for ScopeHandedOver status in search IPO

* Rename

* Allow admin to delete IPOs with status ScopeHandedOver

---------

Co-authored-by: VRiveland <vriv@equinor.com>
chormaz added a commit that referenced this pull request Sep 13, 2023
* Bump qs from 6.11.0 to 6.11.2

Bumps [qs](https://github.com/ljharb/qs) from 6.11.0 to 6.11.2.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.11.0...v6.11.2)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* feature/80600-IPO-ønsker-mc-pakke-status-i-selected-scope-info (#766)

* Added m1, m02 info + status to selected scope info

* removed logging

* Formatted the date

* Feature/104582 handle scope handed over status (#768)

* Added ScopeHandedOver enumm and added to filter

* Unable to edit when scope handed over

* Removed step created when handed over

* Cannot edit when scope handed over

* Renamed files

* Improve readability for ScopeHandedOver status in search IPO

* Rename

* Allow admin to delete IPOs with status ScopeHandedOver

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/104099 ipo lage knapp for å opprette teamsmøte innkallelse frontend (#767)

* Added checkbox in invitation to make teamsmeeting

* fixed warning with EdsIcon inside button

* changed back to edsIcon

* Show teamsmeeting as checked on editview

* Addes styling to teams meeting checkbox

* Changed how teams meeting is shown in view IPO

* Changed wording in create IPO

* Small changes

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/80834 UI disable mc pkgs with signed rfoc (#769)

* Added     operationHandoverStatus on types

* set disableCheckbox to true

* Disabled checkbox doesnt get selected on selectall

* New column in table with checkbox if rfoc accepted

* Fixed check all not working properly

* Moved RFOC column to before MC column in DP comm table

* Disabling MCpkg column i comm table when RFOC is accepted

* Removed disabling MC button when RFOC has status accepted

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* docs(readme): remove white spaces to trigger build

* fix: package.json & yarn.lock to reduce vulnerabilities (#765)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Revert "fix: package.json & yarn.lock to reduce vulnerabilities (#765)" (#775)

This reverts commit 63d8e17.

* Bump node from 14.17.0 to 20.2.0 in /.docker (#759)

* Bump node from 14.17.0 to 20.2.0 in /.docker

Bumps node from 14.17.0 to 20.2.0.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* give permissions to labeler-action ref:actions/labeler#12

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AnneSkje <114983853+AnneSkje@users.noreply.github.com>
Co-authored-by: VRiveland <vriv@equinor.com>
Co-authored-by: Kristoffer Steen <KRST@equinor.com>
Co-authored-by: Kristoffer Steen <kristoffer.steen@hotmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christian Hormazabal <78788930+chormaz@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>
chormaz pushed a commit that referenced this pull request Sep 13, 2023
* Added ScopeHandedOver enumm and added to filter

* Unable to edit when scope handed over

* Removed step created when handed over

* Cannot edit when scope handed over

* Renamed files

* Improve readability for ScopeHandedOver status in search IPO

* Rename

* Allow admin to delete IPOs with status ScopeHandedOver

---------

Co-authored-by: VRiveland <vriv@equinor.com>
chormaz added a commit that referenced this pull request Sep 13, 2023
* Bump qs from 6.11.0 to 6.11.2

Bumps [qs](https://github.com/ljharb/qs) from 6.11.0 to 6.11.2.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.11.0...v6.11.2)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* feature/80600-IPO-ønsker-mc-pakke-status-i-selected-scope-info (#766)

* Added m1, m02 info + status to selected scope info

* removed logging

* Formatted the date

* Feature/104582 handle scope handed over status (#768)

* Added ScopeHandedOver enumm and added to filter

* Unable to edit when scope handed over

* Removed step created when handed over

* Cannot edit when scope handed over

* Renamed files

* Improve readability for ScopeHandedOver status in search IPO

* Rename

* Allow admin to delete IPOs with status ScopeHandedOver

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/104099 ipo lage knapp for å opprette teamsmøte innkallelse frontend (#767)

* Added checkbox in invitation to make teamsmeeting

* fixed warning with EdsIcon inside button

* changed back to edsIcon

* Show teamsmeeting as checked on editview

* Addes styling to teams meeting checkbox

* Changed how teams meeting is shown in view IPO

* Changed wording in create IPO

* Small changes

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/80834 UI disable mc pkgs with signed rfoc (#769)

* Added     operationHandoverStatus on types

* set disableCheckbox to true

* Disabled checkbox doesnt get selected on selectall

* New column in table with checkbox if rfoc accepted

* Fixed check all not working properly

* Moved RFOC column to before MC column in DP comm table

* Disabling MCpkg column i comm table when RFOC is accepted

* Removed disabling MC button when RFOC has status accepted

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* docs(readme): remove white spaces to trigger build

* fix: package.json & yarn.lock to reduce vulnerabilities (#765)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Revert "fix: package.json & yarn.lock to reduce vulnerabilities (#765)" (#775)

This reverts commit 63d8e17.

* Bump node from 14.17.0 to 20.2.0 in /.docker (#759)

* Bump node from 14.17.0 to 20.2.0 in /.docker

Bumps node from 14.17.0 to 20.2.0.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* give permissions to labeler-action ref:actions/labeler#12

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AnneSkje <114983853+AnneSkje@users.noreply.github.com>
Co-authored-by: VRiveland <vriv@equinor.com>
Co-authored-by: Kristoffer Steen <KRST@equinor.com>
Co-authored-by: Kristoffer Steen <kristoffer.steen@hotmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christian Hormazabal <78788930+chormaz@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>
chormaz added a commit that referenced this pull request Sep 13, 2023
* Bump nginx from 1.21.6-alpine to 1.25.0-alpine in /.docker

Bumps nginx from 1.21.6-alpine to 1.25.0-alpine.

---
updated-dependencies:
- dependency-name: nginx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* feature/80600-IPO-ønsker-mc-pakke-status-i-selected-scope-info (#766)

* Added m1, m02 info + status to selected scope info

* removed logging

* Formatted the date

* Feature/104582 handle scope handed over status (#768)

* Added ScopeHandedOver enumm and added to filter

* Unable to edit when scope handed over

* Removed step created when handed over

* Cannot edit when scope handed over

* Renamed files

* Improve readability for ScopeHandedOver status in search IPO

* Rename

* Allow admin to delete IPOs with status ScopeHandedOver

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/104099 ipo lage knapp for å opprette teamsmøte innkallelse frontend (#767)

* Added checkbox in invitation to make teamsmeeting

* fixed warning with EdsIcon inside button

* changed back to edsIcon

* Show teamsmeeting as checked on editview

* Addes styling to teams meeting checkbox

* Changed how teams meeting is shown in view IPO

* Changed wording in create IPO

* Small changes

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/80834 UI disable mc pkgs with signed rfoc (#769)

* Added     operationHandoverStatus on types

* set disableCheckbox to true

* Disabled checkbox doesnt get selected on selectall

* New column in table with checkbox if rfoc accepted

* Fixed check all not working properly

* Moved RFOC column to before MC column in DP comm table

* Disabling MCpkg column i comm table when RFOC is accepted

* Removed disabling MC button when RFOC has status accepted

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* docs(readme): remove white spaces to trigger build

* fix: package.json & yarn.lock to reduce vulnerabilities (#765)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Revert "fix: package.json & yarn.lock to reduce vulnerabilities (#765)" (#775)

This reverts commit 63d8e17.

* Bump node from 14.17.0 to 20.2.0 in /.docker (#759)

* Bump node from 14.17.0 to 20.2.0 in /.docker

Bumps node from 14.17.0 to 20.2.0.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* give permissions to labeler-action ref:actions/labeler#12

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>

* Bump qs from 6.11.0 to 6.11.2 (#761)

* Bump qs from 6.11.0 to 6.11.2

Bumps [qs](https://github.com/ljharb/qs) from 6.11.0 to 6.11.2.
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](ljharb/qs@v6.11.0...v6.11.2)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* feature/80600-IPO-ønsker-mc-pakke-status-i-selected-scope-info (#766)

* Added m1, m02 info + status to selected scope info

* removed logging

* Formatted the date

* Feature/104582 handle scope handed over status (#768)

* Added ScopeHandedOver enumm and added to filter

* Unable to edit when scope handed over

* Removed step created when handed over

* Cannot edit when scope handed over

* Renamed files

* Improve readability for ScopeHandedOver status in search IPO

* Rename

* Allow admin to delete IPOs with status ScopeHandedOver

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/104099 ipo lage knapp for å opprette teamsmøte innkallelse frontend (#767)

* Added checkbox in invitation to make teamsmeeting

* fixed warning with EdsIcon inside button

* changed back to edsIcon

* Show teamsmeeting as checked on editview

* Addes styling to teams meeting checkbox

* Changed how teams meeting is shown in view IPO

* Changed wording in create IPO

* Small changes

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* Feature/80834 UI disable mc pkgs with signed rfoc (#769)

* Added     operationHandoverStatus on types

* set disableCheckbox to true

* Disabled checkbox doesnt get selected on selectall

* New column in table with checkbox if rfoc accepted

* Fixed check all not working properly

* Moved RFOC column to before MC column in DP comm table

* Disabling MCpkg column i comm table when RFOC is accepted

* Removed disabling MC button when RFOC has status accepted

---------

Co-authored-by: VRiveland <vriv@equinor.com>

* docs(readme): remove white spaces to trigger build

* fix: package.json & yarn.lock to reduce vulnerabilities (#765)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Revert "fix: package.json & yarn.lock to reduce vulnerabilities (#765)" (#775)

This reverts commit 63d8e17.

* Bump node from 14.17.0 to 20.2.0 in /.docker (#759)

* Bump node from 14.17.0 to 20.2.0 in /.docker

Bumps node from 14.17.0 to 20.2.0.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* give permissions to labeler-action ref:actions/labeler#12

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AnneSkje <114983853+AnneSkje@users.noreply.github.com>
Co-authored-by: VRiveland <vriv@equinor.com>
Co-authored-by: Kristoffer Steen <KRST@equinor.com>
Co-authored-by: Kristoffer Steen <kristoffer.steen@hotmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christian Hormazabal <78788930+chormaz@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AnneSkje <114983853+AnneSkje@users.noreply.github.com>
Co-authored-by: VRiveland <vriv@equinor.com>
Co-authored-by: Kristoffer Steen <KRST@equinor.com>
Co-authored-by: Kristoffer Steen <kristoffer.steen@hotmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Christian Hormazabal <78788930+chormaz@users.noreply.github.com>
Co-authored-by: Christian Alejandro Hormazabal Martin <chorm@equinor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invitation for punchout Changes to the IPO module missing test There doesnt seem to be a test associated with this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants