Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show events on components and replicas #698

Merged
merged 19 commits into from
Oct 30, 2024

Conversation

satr
Copy link
Contributor

@satr satr commented Oct 29, 2024

No description provided.

@satr satr requested a review from Richard87 October 29, 2024 11:56
@satr satr self-assigned this Oct 29, 2024
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, a linting bug, and a test is failing, but the rest looks good 👍

api/events/models/ingress_builder.go Outdated Show resolved Hide resolved
@satr satr requested a review from Richard87 October 29, 2024 16:01
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satr satr merged commit 45ad500 into master Oct 30, 2024
6 checks passed
@satr satr deleted the show-events-on-components-and-replicas branch October 30, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants