fix dev test, simplify logic

equinor · Nov 28, 2024 · 1c680bf · 1c680bf
1 parent fb32416
commit 1c680bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/src/components/page-scheduled-batch/dev.tsx b/src/components/page-scheduled-batch/dev.tsx
@@ -6,7 +6,7 @@ import type { ScheduledBatchSummary } from '../../store/radix-api';
 
 const testData: Array<
   Parameters<typeof PageScheduledBatch>[0] & {
-    batchData?: ScheduledBatchSummary;
+    batchData: ScheduledBatchSummary;
   }
 > = [
   {
@@ -131,12 +131,6 @@ const testData: Array<
       ],
     },
   },
-  {
-    appName: 'empty-app',
-    envName: 'empty-env',
-    jobComponentName: 'empty-component',
-    scheduledBatchName: 'no-btch',
-  },
 ];
 
 // Mock API response
@@ -146,7 +140,6 @@ new Server({
     testData.forEach(({ scheduledBatchName, batchData }) => {
       this.get(
         `/api/v1/applications/:appName/environments/:envName/jobcomponents/:jobComponentName/batches/${scheduledBatchName}`,
-        // @ts-expect-error no idea why batchdata fails
         () => batchData
       );
     });

diff --git a/src/components/page-scheduled-batch/scheduled-batch-overview.tsx b/src/components/page-scheduled-batch/scheduled-batch-overview.tsx
@@ -39,11 +39,6 @@ const ScheduledBatchDuration = ({ started, finished }: Props) => {
   );
 };
 
-type ScheduledBatchStateProps = Pick<ScheduledBatchSummary, 'status'>;
-const ScheduledBatchState = ({ status }: ScheduledBatchStateProps) => (
-  <>{status && <ProgressStatusBadge status={status} />}</>
-);
-
 type ScheduledBatchOverviewProps = {
   batch: ScheduledBatchSummary;
   jobComponentName: string;
@@ -70,7 +65,7 @@ export const ScheduledBatchOverview = ({
           </Typography>
           {batch.status && (
             <Typography className="status-title">
-              Batch status <ScheduledBatchState status={batch.status} />
+              Batch status <ProgressStatusBadge status={batch.status} />
             </Typography>
           )}
           <Typography className="status-title">