Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show used resources #1097

Merged
merged 16 commits into from
Oct 1, 2024
Merged

Show used resources #1097

merged 16 commits into from
Oct 1, 2024

Conversation

satr
Copy link
Contributor

@satr satr commented Sep 23, 2024

No description provided.

@satr satr requested a review from Richard87 September 23, 2024 12:12
@satr satr self-assigned this Sep 23, 2024
Richard87
Richard87 reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'm not sure about the UX

image
I don't think the popup is necessary, the actual number could just be a title prop on the text field, and its weird that some fields have the unit, while others do not

@satr satr requested a review from Richard87 September 23, 2024 13:03
Richard87
Richard87 previously approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godkjet

Richard87
Richard87 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Richard87 Richard87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@satr satr merged commit 8d0183e into master Oct 1, 2024
5 checks passed
@satr satr deleted the show-used-resources branch October 1, 2024 12:22
satr added a commit that referenced this pull request Oct 2, 2024
@satr
Merge pull request #1109 from equinor/master
95d1b48 
Show used resources (#1097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richard87 Richard87 Richard87 approved these changes

Assignees

@satr satr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satr @Richard87