Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build to release albeit without testing. #866

Closed
wants to merge 11 commits into from

Conversation

trhallam
Copy link
Contributor

Issue
Resolves #726

Approach

Include windows MSVC build environment in github workflow but exclude windows from testing due to an error in the creation of temporary memory.

I'm currently building these as unofficial artifacts for windows but if you feel they could be included in the main trunk then I make this pull request available.

@ertomatic
Copy link
Collaborator

Can one of the admins verify this patch?

@lars-petter-hauge
Copy link
Contributor

Hi @trhallam

Thanks for the PR! Unfortunately we can not ship releases for a platform that does not have tests running. I can understand the frustration of having to compile locally every time you want to install the package though.. I believe workarounds like WSL has already been mentioned in the issue you are referring to.

@trhallam
Copy link
Contributor Author

Ok, no problem, if you fix the issue where the custom test area is hard coded into the tests to suit linux then I think the tests might pass. I'll just continue to have the shadow releases in my fork.

I'd also suggest that WSL is not always a solution for people because some IT departments are still wary of providing WSL support. People with less knowledge also struggle to understand some of the nuance of WSL which makes ECL less accessible.

Non-the-less, appreciate all the work that has gone into this package.

@trhallam trhallam closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using pip install libecl on Window?
3 participants