Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build to release albeit without testing. #866

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: ['ubuntu-latest', 'macos-latest']
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
python: ['3.6', '3.7', '3.8', '3.9', '3.10']

runs-on: ${{ matrix.os }}
Expand All @@ -69,8 +69,15 @@ jobs:
with:
python-version: ${{ matrix.python }}

- name: Setup VS-devshell
uses: egor-tensin/vs-shell@v2
with:
arch: x64
if: matrix.os == 'windows-latest'

- name: Build macOS/Windows Wheel
run: pip wheel . --no-deps -w dist
run:
pip wheel . --no-deps -w dist
if: matrix.os != 'ubuntu-latest'

- name: Upload wheel as artifact
Expand All @@ -92,8 +99,13 @@ jobs:
path: dist-migration/*
if: matrix.os == 'ubuntu-latest' && matrix.python == '3.6'

- name: Install ecl
- name: Install ecl Ubuntu/Macosx
run: pip install dist/*
if: matrix.os != 'windows-latest'

- name: Install ecl Windows
run: pip install (dir dist/*)
if: matrix.os == 'windows-latest'

- name: Run Python tests
run: |
Expand All @@ -118,6 +130,7 @@ jobs:

# Run tests
python -m pytest python/tests
if: matrix.os != 'windows-latest'


publish:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ __ecl_lib_info.py
/_skbuild/
/python/ecl/version.py
.*
!.github
*.egg-info/

/dist
Expand Down