-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign keywork for RD_SMSPEC_NETWORK_VAR #951
Conversation
6dd5ecb
to
7918705
Compare
ffc75ec
to
054b04a
Compare
Alif Be wrote: resdata/lib/resdata/smspec_node.cpp Line 567 in 4062d1e
smspec_node.cpp this->var_type == RD_SMSPEC_LOCAL_WELL_VAR) https://github.com/[equinor/resdata](https://github.com/equinor/resdata)|equinor/resdataequinor/resdata | Added by GitHub 12:24 tested on troll dataset and seems to work |
Looks good, but are we sure that network variables always have well names? In any case, we now need to change the following: https://github.com/equinor/ert/blob/e35e7e07b39534ac3ed83085a87a970b633dcc70/src/ert/config/_read_summary.py#L167-L170 |
Yes, network vector is always have a node name which is stored in either WGNAMES or NAMES. There are obviously some special vectors which are beginning with N but not network vector. See this commit OPM/ResInsight@1cf2cd7 |
We checked and it seems that WGNAMES or NAMES will be present for network variables. |
Compare network variables using wgnames Network variables have only rates Network variables are either juntions or pipes, e.g. NJOPR, NJWPR, NPGFR. Ref. Intersect manual p1619 onwards.
a5cda3f
to
c3833cc
Compare
Network variables are either juntions or pipes, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this seems to be correct.
Issue
Resolves #943
Picks changes from commit OPM/ResInsight@70f31aa
Alif has tested using Troll data. ✅