Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign keywork for RD_SMSPEC_NETWORK_VAR #951

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Jan 29, 2024

Issue
Resolves #943

Picks changes from commit OPM/ResInsight@70f31aa

⚠️ Currently untested, awaiting access to Troll to try to replicate Network vectors in summary.
Alif has tested using Troll data. ✅

@andreas-el andreas-el force-pushed the add_keyword_network_summary branch 3 times, most recently from 6dd5ecb to 7918705 Compare January 29, 2024 08:48
@andreas-el andreas-el changed the title Assign keywork for ECL_SMSPEC_NETWORK_VAR Assign keywork for RD_SMSPEC_NETWORK_VAR Jan 29, 2024
@andreas-el andreas-el force-pushed the add_keyword_network_summary branch 2 times, most recently from ffc75ec to 054b04a Compare February 5, 2024 11:43
@andreas-el
Copy link
Contributor Author

Alif Be wrote:
I think I figure out the problem. wgname is not defined for network keyword
12:23
we need to add network to this line

this->var_type == RD_SMSPEC_LOCAL_WELL_VAR)

smspec_node.cpp
this->var_type == RD_SMSPEC_LOCAL_WELL_VAR)
https://github.com/[equinor/resdata](https://github.com/equinor/resdata)|equinor/resdataequinor/resdata | Added by GitHub
12:24
tested on troll dataset and seems to work

@eivindjahren
Copy link
Collaborator

eivindjahren commented Feb 5, 2024

Looks good, but are we sure that network variables always have well names? In any case, we now need to change the following: https://github.com/equinor/ert/blob/e35e7e07b39534ac3ed83085a87a970b633dcc70/src/ert/config/_read_summary.py#L167-L170

@alifbe
Copy link

alifbe commented Feb 5, 2024

Looks good, but are we sure that network variables always have well names? In any case, we now need to change the following: https://github.com/equinor/ert/blob/e35e7e07b39534ac3ed83085a87a970b633dcc70/src/ert/config/_read_summary.py#L167-L170

Yes, network vector is always have a node name which is stored in either WGNAMES or NAMES. There are obviously some special vectors which are beginning with N but not network vector.

See this commit OPM/ResInsight@1cf2cd7

@eivindjahren
Copy link
Collaborator

We checked and it seems that WGNAMES or NAMES will be present for network variables.

Compare network variables using wgnames
Network variables have only rates
Network variables are either juntions or pipes, e.g.
NJOPR, NJWPR, NPGFR.
Ref. Intersect manual p1619 onwards.
@andreas-el andreas-el force-pushed the add_keyword_network_summary branch from a5cda3f to c3833cc Compare February 5, 2024 14:37
@andreas-el
Copy link
Contributor Author

Network variables are either juntions or pipes, e.g.
NJOPR, NJWPR, NPGFR.
Ref. Intersect manual p1619 onwards.

Copy link
Collaborator

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this seems to be correct.

@eivindjahren eivindjahren merged commit 2df4dab into main Feb 5, 2024
35 of 37 checks passed
@eivindjahren eivindjahren deleted the add_keyword_network_summary branch February 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EclSum doesn't read network vectors
3 participants