Remove broken replace_kw from ResdataFile #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function referenced the field data_owner from ResdataKw which is never set, except after the lookup and then it is set to False. The only possible outcome of calling the function is AttributeError so we are only removing undefined behavior in terms of semver.
eivindjahren
force-pushed
the
remove_broken_replace_kw
branch
from
7474217 to
1efd234
Compare
eivindjahren
changed the title
eivindjahren
force-pushed
the
remove_broken_replace_kw
branch
from
1efd234 to
61e7a91
Compare
These functions have thrown NotImplementedError for a long time so it should now be considered removing undefined behavior in terms of semver.
eivindjahren
force-pushed
the
remove_broken_replace_kw
branch
from
61e7a91 to
b8c2e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function referenced the field data_owner from
ResdataKW which is never set, except after the lookup
and then it is set to False.
The only possible outcome of calling the function is
AttributeError so we are only removing undefined behavior
in terms of semver.
Also removes deprecated functions:
These functions have thrown NotImplementedError for a long
time so it should now be considered removing undefined
behavior in terms of semver.