Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interp_relperm Allow two phase interpolation #701

Merged
merged 3 commits into from
May 24, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented May 23, 2024

Closes #168

@alifbe alifbe requested review from berland and a team May 24, 2024 06:08
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this to allow for merging since the changes are not numerous, but I of course cannot comment on correctness.

Just a leftover print statement to be removed 😄

src/subscript/interp_relperm/interp_relperm.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (f56fde2) to head (1c1ea64).
Report is 10 commits behind head on main.

Current head 1c1ea64 differs from pull request most recent head 84edf34

Please upload reports for the commit 84edf34 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
- Coverage   85.69%   85.55%   -0.15%     
==========================================
  Files          50       49       -1     
  Lines        7005     6577     -428     
==========================================
- Hits         6003     5627     -376     
+ Misses       1002      950      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe merged commit 9f70d93 into equinor:main May 24, 2024
6 checks passed
@alifbe alifbe deleted the interp_relperm_fix branch May 24, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[interp_relperm] Support two-phase oil-water
3 participants