Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WellLogViewer, Python - Prevent cropping of unit in readout #1888

Open
eirik-morken opened this issue Jan 25, 2024 · 3 comments
Open

WellLogViewer, Python - Prevent cropping of unit in readout #1888

eirik-morken opened this issue Jan 25, 2024 · 3 comments
Labels
enhancement New feature or request well-log-viewer

Comments

@eirik-morken
Copy link

eirik-morken commented Jan 25, 2024 •
edited
Loading

There is an issue where a long value in the readout is not scaled properly, leading to the readout extending outside the visible box. This should say "g/cm3".
image

Recreated in storybook where MFOA gets too many numbers, here just the outer line disappears. If the combined length of number and unit is too long then the unit starts to disappear.
image

This is always prevalent in my viewer. Making the box the viewer exists in larger does not help as the viewer just scales accordingly and same problem occurs.
Is this a bug that could be fixed or is there some workaround?
@eirik-morken
Copy link
Author

Any updates/suggestions on how to solve this issue? The users get caught up on this.

@anders-kiaer
Copy link
Collaborator

Thanks for the report @eirik-morken. What would be the preferred general solution here? Limit readout to X significant digits?

@eirik-morken
Copy link
Author

It could be limit amount of digits, dynamically or manually have more flexibility to increase size of readout or a mix of both I guess.

@Vladimir-Kokin Vladimir-Kokin mentioned this issue Feb 29, 2024
Merged
Vladimir-Kokin added a commit that referenced this issue Mar 5, 2024
@Vladimir-Kokin
feat: Track caption and readout font size and text truncation (#1941)
ff14b41 
- Refactor readout code, set HTML elements CSS props with CSS style when possible to allow it customization: font size, readout and readout elements widthes and so on
- Long track captions, readout names, values and units truncated with ellipsys
- Add tooltips to show not truncated text

See #1715, #1874, #1888
hkfb pushed a commit that referenced this issue Mar 5, 2024
@semantic-release-bot
chore(release): well-log-viewer@1.5.0 [skip ci]
44d5298 
# [1.5.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.4.8...well-log-viewer@1.5.0) (2024-03-05)

### Features

* Track caption and readout font size and text truncation ([#1941](#1941)) ([ff14b41](ff14b41)), closes [#1715](#1715) [#1874](#1874) [#1888](#1888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request well-log-viewer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anders-kiaer @eirik-morken @Vladimir-Kokin