New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NGRM] - SyncLogViewer is not working if wrapped with React.StrictMode component #2110

Closed

mirisb opened this issue Jun 19, 2024 · 2 comments

Labels

bug well-log-viewer

Collaborator

mirisb commented Jun 19, 2024

Introduction:
React.StrictMode component is used to debug components and make sure they are written correctly. https://react.dev/reference/react/StrictMode
StrictMode is only active in dev mode thus it is not in effect when running production mode.

Problem:
When wrapping SyncLogViewer in StrictMode it becomes disfunctional:

Also in Dev Tools console we see errors:

This problem is interfering with development and also indicates a malfunction in the SyncLogView component.

Vladimir-Kokin added the well-log-viewer label

Collaborator

Vladimir-Kokin commented Jun 26, 2024 •

edited

Loading

One sort of strict mode warnings in the console was removed in PR #2087 (commit)
Another sort of warnings (as in the issue description) still exists

Vladimir-Kokin added the bug label

Vladimir-Kokin mentioned this issue

fix: StrictMode behaviour #2139

Merged

Vladimir-Kokin added a commit that referenced this issue


          fix: StrictMode behaviour (#2139)

807fff4

- fix StrictMode; (See #2110)
- fix missed props.domain in WLV
- fix primaryAxes notification processing (TVD/MD switch)
- add onDeleteController callback to SyncLogViewer props
(#2053 (comment))

hkfb pushed a commit that referenced this issue


          chore(release): well-log-viewer@1.11.0 [skip ci]

428d976

# [1.11.0](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.10.1...well-log-viewer@1.11.0) (2024-07-18)

### Bug Fixes

* bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([#2120](#2120)) ([614bc81](614bc81))
* bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([#2144](#2144)) ([888d147](888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [#2158](#2158) [#2237](#2237) [#2177](#2177) [#2173](#2173) [#2393](https://github.com/equinor/webviz-subsurface-components/issues/2393) [#2166](#2166) [#2183](#2183) [#2106](#2106) [#2106](#2106) [#2247](#2247) [#2247](#2247) [#2247](#2247) [#2613](https://github.com/equinor/webviz-subsurface-components/issues/2613) [#1896](#1896) [#2217](#2217) [#2231](#2231) [#1893](#1893) [#2033](#2033) [#2338](#2338) [#2415](https://github.com/equinor/webviz-subsurface-components/issues/2415) [#1450](#1450) [#2149](#2149) [#2323](#2323) [#2142](#2142) [#2316](#2316) [#2345](#2345) [#2178](#2178) [#2168](#2168) [#2174](#2174) [#2182](#2182) [#2171](#2171) [#2171](#2171) [#2167](#2167) [#2134](#2134) [#2169](#2169) [#2195](#2195) [#2216](#2216) [#2227](#2227) [#2172](#2172) [#2475](https://github.com/equinor/webviz-subsurface-components/issues/2475) [#2504](https://github.com/equinor/webviz-subsurface-components/issues/2504) [#2524](https://github.com/equinor/webviz-subsurface-components/issues/2524) [#2609](https://github.com/equinor/webviz-subsurface-components/issues/2609) [#2607](https://github.com/equinor/webviz-subsurface-components/issues/2607) [#2603](https://github.com/equinor/webviz-subsurface-components/issues/2603) [#2599](https://github.com/equinor/webviz-subsurface-components/issues/2599) [#2565](https://github.com/equinor/webviz-subsurface-components/issues/2565) [#2576](https://github.com/equinor/webviz-subsurface-components/issues/2576) [#2572](https://github.com/equinor/webviz-subsurface-components/issues/2572) [#2571](https://github.com/equinor/webviz-subsurface-components/issues/2571)
* bump ajv from 8.14.0 to 8.16.0 in /typescript ([#2138](#2138)) ([3f02100](3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [#2444](https://github.com/equinor/webviz-subsurface-components/issues/2444) [#2442](https://github.com/equinor/webviz-subsurface-components/issues/2442) [#2415](https://github.com/equinor/webviz-subsurface-components/issues/2415)
* bump mathjs from 12.4.2 to 13.0.0 in /typescript ([#2124](#2124)) ([caae3f2](caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#1240](#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198)
* Crash Removing Well Log in SLV ([#2122](#2122)) ([4139860](4139860)), closes [#2114](#2114)
* Property "setControllerDefaultZoom" does not exist on type "WellLogController" ([#2136](#2136)) ([a2390e2](a2390e2))
* semantic release not publishing ([#2160](#2160)) ([235c558](235c558))
* semantic release not publishing ([#2164](#2164)) ([9878239](9878239))
* StrictMode behaviour ([#2139](#2139)) ([807fff4](807fff4)), closes [#2110](#2110) [/github.com//issues/2053#issuecomment-2194025734](https://github.com//github.com/equinor/webviz-subsurface-components/issues/2053/issues/issuecomment-2194025734)

### Features

* color function ([#2054](#2054)) ([#2152](#2152)) ([36b85bb](36b85bb))

Collaborator Author

mirisb commented Jul 25, 2024

After #2139 there are no more errors in console while strict mode is active and component is working smoothly.

mirisb closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment