Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Emit interpolated curve information #2205

Merged
merged 9 commits into from
Aug 28, 2024
Merged

fix: Emit interpolated curve information #2205

merged 9 commits into from
Aug 28, 2024

Conversation

Anders2303
Copy link
Collaborator

@Anders2303 Anders2303 commented Aug 27, 2024 •
edited
Loading

Solves #2196

  1. Moved the "fillInfo" computation from the WellLogInfoPanel component up to the WellLogViewer and SyncLogViewer core components
  2. Added a onInfoFilled event to the CallbackManager, and made the info-panel listen to that instead
  3. Made the viewer-components emit a onInfoFilled event, to expose the interpolated data to external components
    1. Story-book example at /story/welllogviewer-demo-welllogviewer--on-info-filled-event

@Anders2303 Anders2303 changed the title fix; Emit interpolated curve information fix: Emit interpolated curve information Aug 27, 2024
@Anders2303 Anders2303 mentioned this pull request Aug 27, 2024
Closed
@hkfb hkfb requested review from Vladimir-Kokin and mirisb August 27, 2024 11:16
@hkfb hkfb merged commit f996eea into equinor:master Aug 28, 2024
10 checks passed
hkfb pushed a commit that referenced this pull request Aug 28, 2024
@semantic-release-bot
chore(release): well-log-viewer@1.12.5 [skip ci]
2512de2 
## [1.12.5](https://github.com/equinor/webviz-subsurface-components/compare/well-log-viewer@1.12.4...well-log-viewer@1.12.5) (2024-08-28)

### Bug Fixes

* Emit interpolated curve information ([#2205](#2205)) ([f996eea](f996eea)), closes [#2196](#2196)
@hkfb
Copy link
Collaborator

hkfb commented Aug 28, 2024

🎉 This issue has been resolved in version well-log-viewer@1.12.5 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkfb hkfb hkfb approved these changes

@Vladimir-Kokin Vladimir-Kokin Awaiting requested review from Vladimir-Kokin

@mirisb mirisb Awaiting requested review from mirisb

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anders2303 @hkfb