-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CO2Leakage: Visual improvements, split plots into tabs, add slider, add options for which category to use for color/markings #1269
Conversation
Update containment plot, show percentages in containment plots, add feedback button
Expand containment plot options
Some failing code style checks in different plugin, _map_viewer_fmu, not sure why. Tests in co2_leakage should be fine. |
* Temp test 1. * Temp test 2. * Quick fix 1. * Quick fix 2. * CCS-127: Clean up fix.
Add "mark by none" option
Add hover info mid-field for the third plot.
This will likely be resolved by #1274 and should not be affecting this PR. |
This PR could benefit from some cleanup and rebasing prior to reviewing. Most commits with |
The plan was to squash all the commits when merging into the master branch. This is what we have done in earlier pull requests, even though the pull request might consist of changes that are not always related to each other (other than being in CO2Leakage-plugin). Should we change this approach? I guess the alternative is to make separate issues in this repo and make a pull request for each issue separately (or combine a few issues in one PR, but with 1 commit per issue). |
First off, I'm not deciding anything here, only voicing a single opinion. |
Ready for review.
CHANGELOG.md
, and added it if should be communicated there.