Move setuptools-scm configuration to pyproject.toml #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
setuptools-fix
branch
2 times, most recently
from
635a3c6
to
6ae7586
Compare
setuptools-scm > 8.0.0 seems to take issue with version file paths supplied in setup.py. This is a step toward a more pyproject.toml oriented package structure as well.
mferrera
force-pushed
the
setuptools-fix
branch
from
6ae7586
to
1a2732a
Compare
mferrera
changed the title
version_file over write_to
Codecov Report
@@ Coverage Diff @@
## main #885 +/- ##
==========================================
+ Coverage 80.78% 80.82% +0.03%
==========================================
Files 87 87
Lines 12887 13038 +151
Branches 2113 2142 +29
==========================================
+ Hits 10411 10538 +127
- Misses 1785 1805 +20
- Partials 691 695 +4
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools-scm 8.0.1 seems to have issues with the version file being provided through the old setup.py function.