Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING, clean-up comments and some imports #21

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Add CONTRIBUTING, clean-up comments and some imports #21

merged 4 commits into from
Nov 30, 2023

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Nov 30, 2023 •
edited
Loading

Resolves #11
Resolves #18
Resolves #19

@mferrera mferrera requested review from tnatt and jcrivenaes November 30, 2023 07:45
@mferrera mferrera self-assigned this Nov 30, 2023
tnatt
tnatt approved these changes Nov 30, 2023
View reviewed changes
Copy link

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice cleaning

@mferrera mferrera merged commit 10e53cc into main Nov 30, 2023
8 checks passed
@mferrera mferrera deleted the repo-maint branch November 30, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnatt tnatt tnatt approved these changes

@jcrivenaes jcrivenaes Awaiting requested review from jcrivenaes

Assignees

@mferrera mferrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double check xtgeo usage and remove where reasonable Add CONTRIBUTING.md Pin numpy < 2.0
2 participants
@mferrera @tnatt