Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various maintenance #41

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Various maintenance #41

merged 4 commits into from
Jul 9, 2024

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Jul 8, 2024

Resolves #34
Resolves #38
Resolves GitHub actions using Node 16 https://github.com/equinor/atlas/issues/36

@mferrera mferrera requested a review from a team July 8, 2024 10:45
jcrivenaes
jcrivenaes approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . One could consider use more of points.get_dataframe(copy=False) in order to return the current underlying dataframe object instead of a copy (when this feels safe). Getting a copy will be slower and more memory demanding.

@mferrera mferrera force-pushed the some-maintenance branch from 13a4c7a to 869852c Compare July 9, 2024 07:10
@mferrera mferrera self-assigned this Jul 9, 2024
@mferrera mferrera merged commit c256789 into equinor:main Jul 9, 2024
8 checks passed
@mferrera mferrera deleted the some-maintenance branch July 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrivenaes jcrivenaes jcrivenaes approved these changes

Assignees

@mferrera mferrera

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mferrera @jcrivenaes