Add support for LedgerBalance. Better data type conversion. Unit Tests

[DashNY]

• Added support for LEDGERBAL tag
• Refactored some logic for better type conversion
• Refactored the datetime parsing, made it clearer. Let me know what you think.
• Added unit tests

[eramella]

Thank you for your PR Alec. Well done. We will need to work on some more tests, now that you add them....:):)
One little thing I would like you to fix. See my notes on ConvertQfxType method.

I also noticed a problem in my code. Some .qfx or .qbo file have different type of transactions but same transaction properties as we have (i.e. investment transaction 'INVTRAN' with nested 'FITID'), this will return a type of PropertyTransaction but the cycle has a null _currentTransaction which throws. We need to check to make sure currentTransaction is not null before calling SetValue(). I will fix it as soon as I have a little time.
Thank you again!

[DashNY]

I'm wondering if there is a way to make it run tests as part of each PR. Any idea?

[eramella]

Yes, with actions, but I have to set it up. This in my future projects.

…

On Wed, Sep 4, 2019, 7:27 PM DashNY ***@***.***> wrote: I'm wondering if there is a way to make it run tests as part of each PR. Any idea? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=AC2HO6XXUGEUBMS3KGY5EH3QIBVCJA5CNFSM4ISRFO22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD55TPQI#issuecomment-528168897>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC2HO6WVM5DHHTTG5K7CAZTQIBVCJANCNFSM4ISRFO2Q> .

[DashNY]

Made the changes you requested. When you have a moment, please merge the PR and publish a nuget.

Not for this PR, but perhaps to improve/unclutter the overall parsing logic, there are parsers out there. The industry standard is ANTLR but it's super bulky (written in Java etc)
I see a better option is Sprache
https://github.com/sprache/Sprache
There is even an example of parsing XML documents.
https://github.com/sprache/Sprache/blob/master/samples/XmlExample/Program.cs
I understand QFX is some weird partial XML format. Still it should be easy enough to implement QFX parser using something like Sprache.

[DashNY]

On another note, I don't have any examples of those .qfx / .ofx files.
If you do, please include them to the unit testing project next to test.qfx.
I'd like to see what they look like. Thanks.

[eramella]

Thank you Alec, I will work on the code during the weekend, merge and push to Nuget.
I really like that Sprache approach! Awesome find. Looks great. The only thing is that this was my pet project to get my feet wet into parsing. Obviously it is not perfect and not very extensible, but I would really like to keep it also in an effort not to depend on other projects, at least for now.
I will include the .qfx file that throws the error. It is a statement from a financial broker but I would need to sanitize the content first. It has transactions with buy and sell flags and others goodies...:).
I started this project to mainly parse credit card transactions that I needed for another project. After long researching for libraries in this fields I decided to build it myself. Obviously this system can be used in other cases as well. Thank you again for expanding its capabilities.