Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Support for extra volume mount in eraser pod #996

Closed
1 task done
jiashun0011 opened this issue Mar 14, 2024 · 1 comment · Fixed by #1061
Closed
1 task done

[REQ] Support for extra volume mount in eraser pod #996

jiashun0011 opened this issue Mar 14, 2024 · 1 comment · Fixed by #1061
Labels
enhancement New feature or request

Comments

@jiashun0011
Copy link

What kind of request is this?

New feature

What is your request or suggestion?

When using eraser in private cloud, we may need mount extra certs to download trivy-db to ensure eraser scanner work as expected.

Currently, eraser pod's lifecycle is controlled by controller manager which means there is no workaround to mount the certs permanently for eraser pod.

Can you help provide some fields in controller_manager_config.yaml where we can define the certs to mount then you can mount them during eraser pod's creation?

Are you willing to submit PRs to contribute to this feature request?

  • Yes, I am willing to implement it.
@jiashun0011 jiashun0011 added the enhancement New feature or request label Mar 14, 2024
@ashnamehrotra
Copy link
Contributor

ashnamehrotra commented Mar 14, 2024

@jiashun0011 there are no fields within controller_manager_config.yaml currently that take in certificates. If you need to mount the certs during eraser pods creation, you would need to pass the value to the manager by creating a new field, and retrieve it in createImageJob function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants