Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for scanner volume mounts #1061

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

lzhecheng
Copy link
Contributor

What this PR does / why we need it:
Add fields for scanner volume mounts
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #996

Special notes for your reviewer:

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files Patch % Lines
api/v1alpha3/zz_generated.deepcopy.go 0.00% 5 Missing ⚠️
api/v1alpha3/zz_generated.conversion.go 0.00% 2 Missing ⚠️
Flag Coverage Δ
unittests 12.56% <0.00%> (-2.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/v1alpha3/eraserconfig_types.go 55.93% <ø> (ø)
api/v1alpha3/zz_generated.conversion.go 0.62% <0.00%> (ø)
api/v1alpha3/zz_generated.deepcopy.go 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@lzhecheng lzhecheng force-pushed the support-mount-cert branch from 55cb84d to cec7560 Compare August 3, 2024 00:28
@ashnamehrotra
Copy link
Contributor

@lzhecheng Thanks for updating! You can run goalngci-lint in order to fix the lint test. It also looks like the collector pipeline test is failing. This tests deploying eraser with "make deploy" instead of helm, which is likely an issue in manifest_staging/charts/eraser/deploy/eraser.yaml

@lzhecheng
Copy link
Contributor Author

@lzhecheng Thanks for updating! You can run goalngci-lint in order to fix the lint test. It also looks like the collector pipeline test is failing. This tests deploying eraser with "make deploy" instead of helm, which is likely an issue in manifest_staging/charts/eraser/deploy/eraser.yaml

You are right. Code updated.
Is there a way I can start tests when I pushed?

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@ashnamehrotra
Copy link
Contributor

@lzhecheng I am not sure why you are unable to run tests, I ran them again.

Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ashnamehrotra ashnamehrotra merged commit 2e13f3f into eraser-dev:main Aug 22, 2024
92 of 94 checks passed
@lzhecheng lzhecheng deleted the support-mount-cert branch August 23, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Support for extra volume mount in eraser pod
2 participants