Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: versioned docs #419

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Conversation

ashnamehrotra
Copy link
Contributor

What this PR does / why we need it:
Fixes versioned docs PR by updating for v0.4.0

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@ashnamehrotra ashnamehrotra marked this pull request as ready for review October 4, 2022 21:51
sozercan
sozercan previously approved these changes Oct 4, 2022
Makefile Outdated Show resolved Hide resolved
docs/yarn.lock Outdated Show resolved Hide resolved
@sozercan sozercan dismissed their stale review October 4, 2022 23:43

see comments

Makefile Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #419 (6210ca4) into main (461764b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   21.41%   21.41%           
=======================================
  Files          10       10           
  Lines         621      621           
=======================================
  Hits          133      133           
  Misses        476      476           
  Partials       12       12           
Flag Coverage Δ
unittests 21.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashnamehrotra ashnamehrotra merged commit ec2cf8b into eraser-dev:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants