fix: Ensure windows nodes are excluded by default #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmengelbert
force-pushed
the
investigate_windows_scheduling
branch
from
fe18bb0
to
fce64ac
Compare
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 15.43% 15.43%
=======================================
Files 13 13
Lines 1600 1600
=======================================
Hits 247 247
Misses 1325 1325
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com>
pmengelbert
force-pushed
the
investigate_windows_scheduling
branch
from
d4925b6
to
c83f1ef
Compare
ashnamehrotra
approved these changes
Feb 18, 2023
ashnamehrotra
pushed a commit
to ashnamehrotra/eraser
that referenced
this pull request
Feb 21, 2023
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> (cherry picked from commit 7379955)
ashnamehrotra
pushed a commit
to ashnamehrotra/eraser
that referenced
this pull request
Feb 21, 2023
Signed-off-by: Peter Engelbert <pmengelbert@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> (cherry picked from commit 7379955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm chart and manifest should define this behavior. Config was not being updated without a call to
Update(), but we shouldn't be changing the config at runtime (gets out of sync with the configmap).