-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci: Scheduled Trivy Scans of Eraser Images #858
Ci: Scheduled Trivy Scans of Eraser Images #858
Conversation
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
The trivy image we use (44.0) has a vulnerability. I ran scans against 44.1 & 45.0 (latest release) and both of those have it as well, so no version we can upgrade to (yet). Not sure if we want to skip the trivy scan in the test for this pr (unsure if possible). I submitted a report just in case it hasn't been noticed yet on Trivy's end. If it gets fixed tomorrow that'll be very :nice: Update Also not sure if backports are done in Trivy or how often, so worst-case we'd need to do a major bump from 44.X to 45.X. |
We can wait for the trivy release to fix this, thanks for checking! |
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
Trivy just released a new version (0.45.1). Scanned it locally and no CVEs, so it should be good to pass now! 🎆 |
@inFocus7 you will also need to update the go.mod for the test to pass |
Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com>
@ashnamehrotra Thanks! I'll update if it fails after this run where I saw I didn't update the tag in Makefile. UpdateLooks like the Trivy scan failed again. It is no longer due to the Trying to think of workarounds:
|
@inFocus7 I added the trivy ignore for now, thank you! |
What this PR does / why we need it:
We currently run Trivy scans during test workflow runs, but want to run them more frequently.
This adds a cron job to run Trivy scans every Monday at 7:00 AM UTC. Those scans are ran against eraser images built on
main
branch.It also allows for manual dispatching to do above and allows running scans of specific release versions.
Each run's vulnerability can also be published to our security tab (I couldn't find a way to make them into issues) if either ran as part of the cron/schedule, or if in our manually dispatch we enable it.
I also added some workflow documentation, only information regarding this action is there, so any new developers can understand it better (hopefully).
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #783
Special notes for your reviewer:
example of a vulnerability caught and recorded, scanning our released v1.1.0 images
as far as i've seen we can't really update the title or metadata, as these are generated straight from the SERIF file generated by the trivy results
There are three runs:
version
input blank (default), which should be building aginst the branch it ran against, then testing those images.version
to the latest beta release, which skips building images, and scans those images.