fix: clean up imagejob when eraser-manager pod is deleted #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
ashnamehrotra
force-pushed
the
fix-pod-template
branch
from
6d14393 to
94e0f20
Compare
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
pmengelbert
pushed a commit
that referenced
this pull request
Sep 28, 2023
pmengelbert
pushed a commit
to pmengelbert/eraser
that referenced
this pull request
Sep 28, 2023
…#875) Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
pmengelbert
added a commit
that referenced
this pull request
Sep 28, 2023
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com> Signed-off-by: Peter Engelbert <pmengelbert@gmail.com> Co-authored-by: ashnamehrotra <ashnamehrotra@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashnamehrotra ashnamehrotra@gmail.com
What this PR does / why we need it:
Cleans up ImageJob when eraser-manager pod is deleted, which deletes PodTemplate. Currently, only the eraser and pod template are cleaned up due to the way the owner references are set. This messes up the ImageJob reconcile since we only cleaned up existing jobs in "first reconcile" before this.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #868
Special notes for your reviewer: