chore: update download and upload artifact to latest #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
|
overwrite:true feature was flakey in the first run (https://github.com/eraser-dev/eraser/actions/runs/7577112778/attempts/1?pr=957) but the tests passed in the second |
ashnamehrotra
added a commit
to ashnamehrotra/eraser
that referenced
this pull request
Jan 25, 2024
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates download and upload artifact to latest. Upload and Download artifact have to be set to the same major version. Upload artifact cut a new release following v4.1.0 that adds ability to overwrite an artifact (https://github.com/actions/upload-artifact/releases) which was throwing an error in PR #954. v4 also doesn't allow mutable artifacts so we have to give each (collector, remover, manager, scanner) a unique name.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: