Skip processing if buffer not modified #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An possible solution to eraserhd#43, can also replace eraserhd#96.
|
Thanks! |
eraserhd
added a commit
that referenced
this pull request
Apr 30, 2021
This reverts commit f570656. Turns out this broke things: if paren mode isn't run before other changes are attempted, the other changes are processed in smart mode, and the parenthesis/indent is broken, messing up the file. The future solution is to delay paren mode until a change is made, but it still must be run before the first change is applied to avoid breaking the file. See #98
|
I reverted this, with these notes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An possible solution to #43, can also replace #96.