Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql resource config error #6479

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iutx
Copy link
Member

@iutx iutx commented Jan 9, 2025

What this PR does / why we need it:

fix mysql resource config error
optimize resources getter

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @sfwn @luobily

ChangeLog

Language Changelog
🇺🇸 English fix mysql resource config error
🇨🇳 中文 修复 mysql 资源配置错误

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

Signed-off-by: Ash <root@viper.run>
@erda-bot
Copy link
Member

erda-bot commented Jan 9, 2025

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6479/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34894: i/o timeout

@iutx iutx marked this pull request as draft January 9, 2025 12:05
Signed-off-by: Ash <root@viper.run>
@iutx iutx requested review from sfwn and luobily January 10, 2025 05:33
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 49.25373% with 34 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (d217119) to head (1724c66).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...orchestrator/scheduler/executor/plugins/k8s/k8s.go 11.76% 15 Missing ⚠️
.../executor/plugins/k8s/addon/sourcecov/sourcecov.go 0.00% 4 Missing ⚠️
.../executor/plugins/k8s/addon/daemonset/daemonset.go 25.00% 3 Missing ⚠️
...r/plugins/k8s/addon/elasticsearch/elasticsearch.go 0.00% 3 Missing ⚠️
...er/executor/plugins/k8s/addon/rocketmq/rocketmq.go 25.00% 3 Missing ⚠️
...r/executor/plugins/k8s/addon/redis/legacy/redis.go 0.00% 2 Missing ⚠️
...rator/scheduler/executor/plugins/k8s/deployment.go 0.00% 2 Missing ⚠️
...tools/orchestrator/scheduler/executor/util/util.go 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6479      +/-   ##
==========================================
- Coverage   15.12%   15.12%   -0.01%     
==========================================
  Files        3675     3675              
  Lines      377005   376894     -111     
==========================================
- Hits        57018    56987      -31     
+ Misses     314540   314457      -83     
- Partials     5447     5450       +3     
Flag Coverage Δ
by-github-actions 15.12% <49.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cheduler/executor/plugins/k8s/addon/canal/canal.go 31.09% <100.00%> (-1.23%) ⬇️
...cheduler/executor/plugins/k8s/addon/mysql/mysql.go 55.50% <100.00%> (-5.69%) ⬇️
...cheduler/executor/plugins/k8s/addon/redis/redis.go 4.79% <100.00%> (-3.80%) ⬇️
...cheduler/executor/plugins/k8s/addon/redis/unify.go 0.00% <ø> (ø)
...r/executor/plugins/k8s/addon/redis/legacy/redis.go 3.53% <0.00%> (ø)
...rator/scheduler/executor/plugins/k8s/deployment.go 37.79% <0.00%> (ø)
...tools/orchestrator/scheduler/executor/util/util.go 37.86% <66.66%> (+0.64%) ⬆️
.../executor/plugins/k8s/addon/daemonset/daemonset.go 5.35% <25.00%> (+0.38%) ⬆️
...r/plugins/k8s/addon/elasticsearch/elasticsearch.go 2.52% <0.00%> (+0.07%) ⬆️
...er/executor/plugins/k8s/addon/rocketmq/rocketmq.go 2.74% <25.00%> (+0.32%) ⬆️
... and 2 more

... and 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants