Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Account for missing version in search page. #492

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Conversation

cmc333333
Copy link
Member

Previously, we were exploding when a version wasn't present in the URL. This
refactors the (rather) messy ChromeView to make testing the changing logic
easier.

Previously, we were exploding when a version wasn't present in the URL. This
refactors the (rather) messy ChromeView to make testing the changing logic
easier.
Copy link
Contributor

@tadhg-ohiggins tadhg-ohiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work tracking this down!

@cmc333333
Copy link
Member Author

Thanks @tadhg-ohiggins

@cmc333333 cmc333333 merged commit 65d9205 into master Aug 10, 2017
cmc333333 pushed a commit that referenced this pull request Aug 10, 2017
Bugfixes
* #492 Prevent 500 when "version" isn't present in search
* #493 Request a page size when searching (will only be effective if regcore
  is >= 4.0.0
* #494 Prevent JS error when paging through search results
* #495 Prevent JS error when back button is pressed in search results
cmc333333 pushed a commit that referenced this pull request Aug 10, 2017
Bugfixes
* #492 Prevent 500 when "version" isn't present in search
* #493 Request a page size when searching (will only be effective if regcore
  is >= 4.0.0
* #494 Prevent JS error when paging through search results
* #495 Prevent JS error when back button is pressed in search results
cmc333333 pushed a commit that referenced this pull request Aug 10, 2017
New Features
* #496 New styles for sidebar

Bugfixes
* #492 Prevent 500 when "version" isn't present in search
* #493 Request a page size when searching (will only be effective if regcore
  is >= 4.0.0
* #494 Prevent JS error when paging through search results
* #495 Prevent JS error when back button is pressed in search results
@cmc333333 cmc333333 deleted the 499-fix-search-500 branch August 14, 2017 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants